Fix tabs/hide-tabs-windows.css on newer Firefox versions

Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox

GNU General Public License v3.0

1.26k stars 120 forks source link

Fix tabs/hide-tabs-windows.css on newer Firefox versions #144

Open craftycorvid opened 5 years ago

craftycorvid commented 5 years ago

Closes #143

Timvde commented 5 years ago

I didn't merge this at first because there was some discussion, but now I merged https://github.com/Timvde/UserChrome-Tweaks/pull/145 without thinking about this open PR... Is that one good too?

BurntFood commented 5 years ago

Tested #145 against this and it has an issue where I am seeing tab names/buttons behind the address bar. This one on the other hand works perfectly. It just needs personal tweaking of a few numbers for the problem @Qwerty-Space has. In my case I just had to change margin-top: -28px; and margin-right: 110px;.

Timvde commented 5 years ago

Any chance those numbers can be generalized? Is this one still better with the wrong numbers? In that case, I'll revert the other one and merge this,

Qwerty-Space commented 5 years ago

I think this one is fine tbh. I was just being a bit nitpicky. Most people probably won't notice.

I also don't have access to a Windows machine to test this on atm