Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 122 forks source link

auto-hide.css breaks Firefox 72 entirely #162

Open LOuroboros opened 4 years ago

LOuroboros commented 4 years ago

There isn't much else to say, really. auto-hide.css breaks Firefox 72 entirely. The browser is not really usable with it alone. https://streamable.com/efz9t

Timvde commented 4 years ago

I just merged #160. This will now only hide the location bar and not the bookmarks toolbar.

LOuroboros commented 4 years ago

It seems to render the bookmar bar unusable, @Timvde. https://streamable.com/ecm78

By the way, is there a separate code to auto-hide the bookmarks bar then, now that it's not included in auto-hide.css? I'll take a look again, but I couldn't find one.

EDIT: I may have found one? I think? It doesn't seem to work well with auto-hide.css though. https://streamable.com/4tj6w

Timvde commented 4 years ago

Hmm, that's pretty useless indeed. In #160, @matt-h links to https://github.com/MrOtherGuy/firefox-csshacks/blob/d6a1a8663dc91db9a72b5fce0e61cf30f22e59e7/chrome/autohide_bookmarks_toolbar.css, does that work for you? I don't know if they can work together.

LOuroboros commented 4 years ago

does that work for you?

Not really. The bookmarks bar is still unusable.

https://streamable.com/yj8gx

Timvde commented 4 years ago

Hmm, that's what I feared... I'm not good enough with CSS to fix this myself. I'm sorry.

matt-h commented 4 years ago

This seemed to work fairly well for me for hiding both the navbar and bookmark bar at once.

#PersonalToolbar:not([customizing]),
#nav-bar:not([customizing="true"]):not([inFullscreen]) {
    min-height: 1px !important;
    max-height: 0px !important;
    margin-top: 1px !important;
    margin-bottom: -1px !important;
    transition: all 50ms linear 0s !important;
    z-index: -5 !important;
}

#navigator-toolbox:hover:not([inFullscreen]) :-moz-any(#nav-bar),
#navigator-toolbox:focus-within :-moz-any(#nav-bar) {
    min-height: 32px !important;
    max-height: 32px !important;
    margin-top: 1px !important;
    margin-bottom: -32px !important;
    transition: all 50ms linear 0s !important;
    z-index: 5 !important;
}

#navigator-toolbox:hover:not([inFullscreen]) :-moz-any(#PersonalToolbar),
#navigator-toolbox:focus-within :-moz-any(#PersonalToolbar) {
    min-height: 32px !important;
    max-height: 32px !important;
    margin-top: 32px !important;
    transition: all 50ms linear 0s !important;
    z-index: 5 !important;
}
sans-c commented 4 years ago

This seemed to work fairly well for me for hiding both the navbar and bookmark bar at once.

Yep, that works for me as well but reintroduces the content shifting. Also the bookmark bar seems a little bigger than before for me. For people who use the bookmark toolbar, its a working solution at none the less

LOuroboros commented 4 years ago

This seemed to work fairly well for me for hiding both the navbar and bookmark bar at once.

That code does seem to work perfectly on my end! https://streamable.com/3djau

EDIT: Though I'm trying to change the size of things for personal use because things look way bigger than they should be to me, and changing the size in pixels of the different min-height and max-height parameters doesn't seem to make much of a difference. I'll keep trying though.

EDIT2: Alright, yeah, it's working perfectly and after a bit of trial-and-error I got it to a size that I am comfortable with. Not too big, and not too small to become unusable. Thank you very very much @matt-h ! https://pastebin.com/QEj0bNfJ

~~EDIT3: I'm experimenting with the code to see if I can make the bars overlap the page currently in view instead of scrolling it down, and I can notice that everything is still working perfectly even if I remove the 3 z-index parameters. Is that normal? Just curious.~~

EDIT4: Ah, this has been an enlightening experience to me. Removing the z-index parameters makes it so you can't right click in the navbar, only in the tabs or the bookmarks bars.

willbelr commented 4 years ago

A little out topic, but as I could not find a satisfying solution, I went for this alternative https://addons.mozilla.org/en-CA/firefox/addon/bookmark-toolbar-menu-button/. Hope this helps