Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 121 forks source link

made the activity stream look decent with dark theme #38

Closed andreicristianpetcu closed 6 years ago

andreicristianpetcu commented 6 years ago

https://imgur.com/a/WcxGk

Timvde commented 6 years ago

Hmm, I actually didn't think about userContent.css tweaks yet.

What does the userChrome.css style exactly? I have a hard time seeing a difference.

andreicristianpetcu commented 6 years ago

userChrome is for Firefox UI while userContent is for the web pages. Things get a little blured since activity stream is made out of web pages inside Firefox.

I had to add this rule in 2 places since there is a small flicker where the initial new tab is made out of Firefox XUL objects and then it is swapped with the Activity stream new tab. I had to make both colored since there would be a flicker from time to time without this.

If you manage to find a simpler solution, I'm all ears :D

Timvde commented 6 years ago

I know what it does :) I just didn't think about it when creating this repository, and I was hoping not to create any dependencies between files (that would make it a lot harder to automate managing the files).

And ah, it's for the initial flicker, that explains a lot :) I don't think there's a better way to do this. I'm going to just accept this PR as as, and worry later about managing userContent.css tweaks and dependencies between multiple styles.

Timvde commented 6 years ago

Oh, one more thing: could you follow the style guidelines for indentation? Just two spaces please :) I'd like to keep code style in this repository more or less consistent. Thanks!

andreicristianpetcu commented 6 years ago

I'll try to do this in a few hours.

andreicristianpetcu commented 6 years ago

it should be fine now

Timvde commented 6 years ago

And you even amended your change, nice! Thank you!

andreicristianpetcu commented 6 years ago

I know it is considered basic politeness on GitHub to squash commits. I personally hate it but as a maintainer I can see the benefit :)