Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 121 forks source link

Autohide bookmarks #42

Closed andreicristianpetcu closed 6 years ago

Timvde commented 6 years ago

I share the concern you outed in this thread. It is currently English-only and Nightly-only. I'm first going to wait whether the original author or someone else comes with a solution. I would also like to see explicit approval from the author that it is okay for them to merge this (and implicitly convert the style to GPL).

andreicristianpetcu commented 6 years ago

Done screenshot from 2017-09-23 20-55-14

nt1m commented 6 years ago

@Timvde asked me if there was a way to work around the english only restriction in the CSS.

This would actually be possible with CSS Selectors 4, but that spec is still a working draft, so I wouldn't expect it to be implemented it soon.

The best bet here to work around the english only restriction would be creating a webextension that sets titlePreface on the window that has about:newtab open. Then, the about:newtab window would be targetable with CSS.

Timvde commented 6 years ago

So, I've been thinking about this, and I don't think that there's an easy way around this. So I'll merge this as-is, with one extra request: could you change Nightly to Mozilla Firefox? This will match the behaviour on release and beta, and Nightly users are more likely to be technical and find out what to change.

andreicristianpetcu commented 6 years ago

I can add selectors for all.

Timvde commented 6 years ago

Oh, lol. Why didn't I even think of that :P Sounds good :)

Timvde commented 6 years ago

@andreicristianpetcu If you add selectors for all Firefox versions and process @nt1m's comment, I'll merge right away :)

andreicristianpetcu commented 6 years ago

I made the extension

andreicristianpetcu commented 6 years ago

I published the extension in AMO https://addons.mozilla.org/en-US/firefox/addon/autohideafternewtab/

andreicristianpetcu commented 6 years ago

any update on this? I did what I was asked :D

Timvde commented 6 years ago

I must have missed your last commit, sorry :) I'll test this tomorrow and merge it if it works ;)

Timvde commented 6 years ago

Seems to work, nice :)