Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 121 forks source link

userFirefox #74

Open jonnyrobbie opened 6 years ago

jonnyrobbie commented 6 years ago

I have made a python3 script using Qt5, which should make managing userChrome tweaks easy with simple gui. Please, consider if this script is convenient enough so that it could be pulled upstream.

There should be only one non-standard python module and that is PyQt5 which needs to be installed as a prerequisite.

If you have any questions, please, ask.

Screenshot preview is here: https://i.imgur.com/sha1iY5.png

Timvde commented 6 years ago

That's definitely something I'd want! But I'm not sure if it is something that should be inside this repository, or something that you would maintain on the side. Do you want to keep on maintaining this yourself, or was your plan to hand over ownership to me?

jonnyrobbie commented 6 years ago

The way I see it is that there is a dilemma. Either adhere to the unix philosophy and keep your set of user tweaks and my helper tool separated in the name of modularity. But then we lose the synergy of more integrated ecosystem. Right now, if someone wanted to use both, he'd be in for a quite a hassle. Be it me keeping the sync with your master or him keeping track of two forks simultaneously or other inconveniences. Or another solution to the dilemma is for you to pull this request, and have two options. Either I'd by supplying you with maintenance pull requests or if it in any way possible, I could tend to this script on my own on this repo directly.

Timvde commented 6 years ago

What's the challenge in staying in sync with my repository? I don't see any files hardcoded (in contrast to this repo, which has a list of all files). If there is anything I can do to make that easier, I'm open for it.

jonnyrobbie commented 6 years ago

Well, if it's something you wanted to do anyways, it's better if it's on a fork where people get to use it more. I wouldn't want my work to get forgotten just because people woudn't want to be bothered to do more cloning, copying or something else. The question I see the most if you want to adhere to the unix philosophy of split modularity or favor more synergy of user convenience of merged forks. That was kinda my idea (inspired by some of your comments where you mentioned a vision of a tool similar to this) to have one easy place where users could do both. I could always just continue my forked repo or even completely separate my tool to a clean repo, but at that point, most people wouldn't bother, which I find a little bit wasteful.

Timvde commented 6 years ago

If visibility is what concerns you, I am definitely willing to put a link to your tool as recommended way to use my repository. My tool is still very rough and can be found here. I never finished it, but I was definitely planning to keep it separate.

What you could do instead (and what I planned to do) was to make your tool download this repository by itself (or make my repository a subtree or something). That way, people wouldn't need to clone my repository themselves. It would just be a data feed for your repository, which would be the main tool.

Timvde commented 6 years ago

If you want to discuss this, you can contact me on Mozilla's IRC server (irc.mozilla.org). Name's just Timvde.

jonnyrobbie commented 6 years ago

I'm sorry I didn't get to reply to you earlier. I think I tend to agree with you that modularity is better.

So I guess I'll close this pull request and I'll try to use your repo as a git submodule. (Unless you have more experience with some other form of inter-git repo mechanism). Then I'll update my manager with single-button repo update functionality and then we try to discuss some more promotion details.

If you agree. :)

Timvde commented 6 years ago

Unless you have more experience with some other form of inter-git repo mechanism

Sadly, I do not. My everyday git knowledge is pretty good, and I know that next to submodules subtrees are also a thing, but I never used them in practice.

Then I'll update my manager with single-button repo update functionality and then we try to discuss some more promotion details.

Sounds like a great idea :) By the way: the plan is for my repository to track Nightly, and I branch off whenever a version rides the train to beta. Because of the high activity in the first few months, this wasn't always in time (because I wanted to get more styles in), but the styles in the "Firefox57" branch are tested and should all be working in Firefox 57, while the ones on master might not work anymore. Same for Firefox 58. So maybe you should consider letting people choose their Firefox version in order not to break stuff.

Timvde commented 6 years ago

Hey @jonnyrobbie, do you have an update of the status? I really like your project, and it would be a pity if it didn't take off.

jonnyrobbie commented 6 years ago

Yes, sorry I've not been paying attention to it lately. I do want to get it to a usable state. I hope I will finally get to it in a few days. Thanks for the patience.