Timvde / UserChrome-Tweaks

A community maintained repository of userChrome.css tweaks for Firefox
GNU General Public License v3.0
1.25k stars 121 forks source link

add dark-navigation-toolbar-dropdown.css #81

Closed hyperfekt closed 6 years ago

hyperfekt commented 6 years ago

CSS to adapt the autocomplete of the navbar from white to the colors of the dark theme.

Timvde commented 6 years ago

Thanks! Could you add newlines in between the different blocks?

I also don't think that element is called "autocomplete". Could you rename it to "navigation toolbar dropdown"? And I'd place it in the navbar folder.

Timvde commented 6 years ago

(In case you checked your mail instead of Github comments, I edited the last comment, I'm not sure if you get a new mail for that)

hyperfekt commented 6 years ago

It's called autocomplete in the HTML source, but it's well possible that's not the official name for it. I will probably make the changes tomorrow, feel free to edit it yourself if you'd like to merge earlier.

Timvde commented 6 years ago

Hmm, it seems that you're right. I'm on the fence. While you're technically correct, I want it to be clear for users, and I believe "location bar dropdown" would be nicer. If you feel strongly otherwise, I will also accept it with its current name, as long as you move it to the navbar directory. That should give enough context.

hyperfekt commented 6 years ago

No, I am definitely in agreement. I was surprised about the naming myself when I discovered it. 'Autocomplete' is far from obvious.

On Wed, Dec 27, 2017, 22:05 Tim Van den Eynde notifications@github.com wrote:

Hmm, it seems that you're right. I'm on the fence. While you're technically correct, I want it to be clear for users, and I believe "location bar dropdown" would be nicer. If you feel strongly otherwise, I will also accept it, as long as you move it to the navbar directory. That should give enough context.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/Timvde/UserChrome-Tweaks/pull/81#issuecomment-354177502, or mute the thread https://github.com/notifications/unsubscribe-auth/AI_2W135Omb4JfiW_88ZXO-oWSaL9MWjks5tErEYgaJpZM4RGC0L .

hyperfekt commented 6 years ago

Here we go. :)

Timvde commented 6 years ago

Awesome, thank you very much!