search

Timvdv / pimatic-zwave-usb

GNU General Public License v2.0
1 stars 7 forks source link

NeoCoolCam power plug support #11

Open thicknesss opened 5 years ago

thicknesss commented 5 years ago

Good day all, and especially Tim, Thanks for all you commitment and the good working plug in. I've a couple of NeoCoolCam Power Plugs which are not (fully) supported by the current code.

With the help of both the powerplug and window sensor devices I've been able the make a device that fully supports these power plugs. It reads Current, Voltage, Power, Energy and state, and it can switch the plug on and off. I would like the share the code so you can incorporate it in the plugin files. (and clean up as nesesarry).

What is the correct way to upload rhe code?

redxeagle commented 5 years ago

Good Morning,

Perfect that you changed the code to make it running. How to contribute is explained really good in this article.

https://help.github.com/articles/creating-a-pull-request-from-a-fork/

So simply create a fork of this repository. Make the change push them and then you can create a pull request for @Timvdv main repository. :)

Greetings Daniel

Timvdv commented 5 years ago

@thicknesss if you already have some working code, it's pretty easy to integrate this into the plugin.

I'm actually not sure if this has to be a new device type or if we can just integrate Current and Voltage attributes to the existing zwave device. Do you know what the best practise is @sweebee?