Closed zz-zye closed 1 year ago
@zz-zye The general rule for translations is do them in batches, no more than 5 new ones at a time because they time time to verify, if you are just updating translations you've done, no more than 10 updated manuals per PR (total of 15 if you are updating and adding new translations).
We'll take it this time, but follow this rule in the future, okay?
I'll be sure to do so from now on. Sorry for the inconvenience.
In case you're wondering what I'm doing, we have a new policy that modules with a lot of CSS and several translations will have their CSS pushed into a file in the HTML/css/Modules folder. And we are NOT going through all 1900 modules to fix that retroactively, we are applying the change whenever there are new translations of manuals like that. Your translations are the first ones since that new policy. Yet another reason to limit your pull requests to 5 new ones and 10 updated ones.
A Translation of 52 modules in Korean. It's the first 52 modules when you sort Centurion modules by name on ktane.timwi.de. The interactives for Hexamaze and Listening, and the Two Factor manual were also translated. I'll do the rest of the Centurion modules soon.
This is a big pull request, so I've summarized what I've done:
File format
3D Maze translated (한국어 — 3D 미로) (Zye).html
Morsematics translated (한국어 — 모스매틱스) (Zye).html
Listening translated (한국어 — 듣기) 인터랙티브 (samfundev, Zye).html
(Interactive) etc.Font & Display tweaks
NotoSerifKR
Regular and Bold were added inHTML/font/korean/
as.woff2
files. This is the official Korean font for the vanilla manual. The font is imported infont-korean.css
.NotoSerifKR
as default in Korean manualsfont-korean.css
was modified so that all Korean HTML files importing it will haveNotoSerifKR
as the default font.I used
font-japanese.css
as reference, which does the same thing.This does affect HTML files already importing
font-korean.css
, but I've found out that the only pre-existing 4 Korean manuals all explicitly use theNanum
font, so there are no major visual changes to any of the pre-existing manuals.Compared to English, Korean characters generally take up a bit more vertical space, and there's no upper/lowercase. So it's a bit harder to read lists if the same amount of margin is used. I've tweaked the
<style>
to add somemargin-bottom
s andword-break: keep-all
to<li>
s and<p>
s when I found it to be more fitting.About the translation