search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.76k stars 150 forks source link

Fix __all__ on win32 #174

Closed srittau closed 1 year ago

srittau commented 1 year ago

sendfile and statvfs are only defined when they are defined in the os module, i.e. not on win32. But they were added to __all__ unconditionally.

srittau commented 1 year ago

For reference, I noticed this when updating the typeshed stubs, cf. python/typeshed#10584.

Tinche commented 1 year ago

Cool, thanks. Can you add a small history entry too?

Tinche commented 1 year ago

Thanks!

srittau commented 1 year ago

Thank you for the quick review!