Return result instead of Future from os funcs wrapper

Tinche / aiofiles

File support for asyncio

Apache License 2.0

2.67k stars 149 forks source link

Return result instead of Future from os funcs wrapper #54

Closed gyermolenko closed 4 years ago

gyermolenko commented 5 years ago

Since support for python3.4 was dropped from the lib I've tried to change from yield from syntax to awaits.

Immediately got into AttributeError: 'Future' object has no attribute st_size in test_os.py::test_stat. Change is small but in return type, so I decided to show it separately.

And another one: here __iter__ has @asyncio.coroutine. I don't think it should (and tests pass without it too :) )

gyermolenko commented 5 years ago

hi @Tinche , just a ping

gyermolenko commented 5 years ago

hi @Tinche . Just a kind reminder.. I am very interested in your thoughts about this PR. (about yield from -> await transition; @asyncio.coroutine above __iter__ etc).

Tinche commented 4 years ago

Thanks!