search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.67k stars 149 forks source link

Another stab at tempfile #56

Closed alemigo closed 3 years ago

alemigo commented 5 years ago

Async tempfile implementation following the existing structure, with a bit extra for SpooledTemporaryFile where delegation is not required unless the in-memory stream is rolled to disk.

bitnom commented 4 years ago

Can you please fix the conflict if you have time? We need a tempfile rolled in. It's been years since adding it was first talked about. Seems like this one should have been merged.

alemigo commented 4 years ago

@Tinche - do you have interest to add this? Can update the pull request and add testing if helpful

alemigo commented 4 years ago

Can you please fix the conflict if you have time? We need a tempfile rolled in. It's been years since adding it was first talked about. Seems like this one should have been merged.

updated

CMCDragonkai commented 3 years ago

Any update on whether this fixes #20?

alemigo commented 3 years ago

you can try https://github.com/alemigo/asynctempfile in the meantime

CMCDragonkai commented 3 years ago

I think this PR can be squashed to be ready for merge.

wagnerflo commented 3 years ago

Can a maintainer please confirm, that this will be merged so I can start using @alemigo's branch now and then switch back to a aiofiles release later?

MajesticMullet commented 3 years ago

Will this be merged soon?

JavierMartinezAlc commented 3 years ago

It will be really helpful if this is released

alemigo commented 3 years ago

https://github.com/alemigo/asynctempfile is the same code for tempfile support as this PR

Tinche commented 3 years ago

Alright, since there's interest I can merge this in. But it needs tests first.

alemigo commented 3 years ago

Alright, since there's interest I can merge this in. But it needs tests first.

Ok I will add

Tinche commented 3 years ago

Alright, since there's interest I can merge this in. But it needs tests first.

Ok I will add

Excellent, thanks. Also some documentation on how to use it would be cool.

alemigo commented 3 years ago

Looks good, left a couple of comments. Also the PR won't merge cleanly for me, might have to rebase on master. Thanks!

Thx - made the changes

Tinche commented 3 years ago

Looks good, thanks a lot!