search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.67k stars 149 forks source link

Python3.8 support #68

Closed tsonglew closed 4 years ago

elonen commented 4 years ago

3.8 support should also include suppressing deprecation warning on @coroutine, as in: https://github.com/Qiskit/qiskit-ibmq-provider/pull/498/files

(Python3.8 deprecated "@coroutine" and "yield from" in favor of "async def" and "await func".)

PikalaxALT commented 4 years ago

Should also replace yield from with await, and get rid of the @asyncio.coroutine decorators so as to phase out support for Python 3.4.

tsonglew commented 4 years ago

hi, @PikalaxALT . Should I replace yield from and @asyncio.coroutine in this pr or create another one? I think suppressing warnings is enough for guys using Python3.8

gyermolenko commented 4 years ago

related #54

blueyed commented 4 years ago

hi, @PikalaxALT . Should I replace yield from and @asyncio.coroutine in this pr or create another one? I think suppressing warnings is enough for guys using Python3.8

IMHO it should not filter them (and if so just in a more central place), but fix them.

I've started doing so, then looked for existing PRs, and noticed that this library appears to be unmaintained currently anyway.

As for this PR I'd say it's good to add the trove classifier (1st commit), and fix the deprecation warnings separately.

Tinche commented 4 years ago

Hi,

thanks for your trouble, I did this myself by modernizing the code base.