search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.67k stars 149 forks source link

Python 3.8 deprecation warnings #70

Closed davesteele closed 4 years ago

davesteele commented 4 years ago

e.g. /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/aiofiles/threadpool/utils.py:33: DeprecationWarning: "@coroutine" decorator is deprecated since Python 3.8, use "async def" instead def method(self, *args, **kwargs):

.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file_sync /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:28: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10. server = yield from asyncio.start_server(serve_file, port=unused_tcp_port,

fakegermano commented 4 years ago

I have this warning too, but they explicitly state that they only support up to python 3.7 But I believe supporting 3.8 is in the roadmap (https://github.com/Tinche/aiofiles/pull/68) , and fixing this issue will be necessary for that step.

Tinche commented 4 years ago

I believe these are fixed in the latest release!

colidyre commented 4 years ago

I believe these are fixed in the latest release!

@Tinche Do you mean on the master branch instead of the tagged release? I have also DeprecationWarning with Pytest on os.py:8 with the latest release 0.5.0 as already mentioned in #74 (which mentioned also #75 and #54).

See the differences for master and latest release 0.5.0 for example. It would be nice to have a tagged version to get rid of the Python3.8 warnings for this version.

samuelcolvin commented 3 years ago

@Tinche any chance you could create a new release to include the fix for this?

Tinche commented 3 years ago

I'll cut a new release tomorrow!

Tinche commented 3 years ago

Released!

samuelcolvin commented 3 years ago

thank you.