search

Tinche / aiofiles

File support for asyncio
Apache License 2.0
2.67k stars 149 forks source link

Deprecation warnings are still present in 0.6.0 #87

Closed davesteele closed 3 years ago

davesteele commented 3 years ago

The second deprecation warning reported in #70 is still present. This will break in Python 3.10.

=============================== warnings summary ===============================
.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file_sync
  /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:26: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    server = await asyncio.start_server(

.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file_sync
  /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:30: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    reader, _ = await asyncio.open_connection(

.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file
  /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:57: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    server = await asyncio.start_server(

.pybuild/cpython3_3.8/build/tests/test_simple.py::test_serve_small_bin_file
  /home/daves/github/aiofiles/.pybuild/cpython3_3.8/build/tests/test_simple.py:61: DeprecationWarning: The loop argument is deprecated since Python 3.8, and scheduled for removal in Python 3.10.
    reader, _ = await asyncio.open_connection(

-- Docs: https://docs.pytest.org/en/latest/warnings.html
==================== 155 passed, 4 warnings in 1.94 seconds ====================
tirkarthi commented 3 years ago

The loop parameter has been removed in Python 3.10 : https://bugs.python.org/issue42392

Tinche commented 3 years ago

Thanks for running our tests :)

I've just removed the loop param.