Missing dependencies in README sample

Tinder / Scarlet

A Retrofit inspired WebSocket client for Kotlin, Java, and Android

Other

3.22k stars 236 forks source link

Missing dependencies in README sample #147

Open michaelbukachi opened 4 years ago

michaelbukachi commented 4 years ago

Hi, I've noticed that the documentation on the README is missing some information such as the dependencies to use. For instance, this line is missing:

implementation 'com.tinder.scarlet:websocket-okhttp:0.1.9'

This makes it difficult to quickly bootstrap a project or follow the setup steps in the README. I can create a PR for this.

francescosalamone commented 3 years ago

@michaelbukachi I also found that if you want to implement the 0.2.4 version (via jitpack) the websocket-okhttp is missing, there are a scarlet-protocol-websocket-okhttp dependency but looks different, becouse Websocket.Event is still not found, so I have to use websocket-okhttp:0.1.9 dependency