Tinder / Scarlet

A Retrofit inspired WebSocket client for Kotlin, Java, and Android
Other
3.23k stars 237 forks source link

STOMP Compatibility #5

Open forresthopkinsa opened 6 years ago

forresthopkinsa commented 6 years ago

The standard for websocket communication is often regarded as being STOMP. Does this / will this library have STOMP compatibility in its message layer?

zhxnlai commented 6 years ago

It is possible to build a STOMP over WebSocket client using Scarlet. You will need to write message adapters for the classes that represent STOMP frames.

forresthopkinsa commented 6 years ago

Cool.

zhxnlai commented 5 years ago

@forresthopkinsa We are working on it: https://github.com/Tinder/Scarlet/tree/0.2.x

Please check out the demo app and tests

alfredorueda commented 5 years ago

@forresthopkinsa We are working on it: https://github.com/Tinder/Scarlet/tree/0.2.x

Please check out the demo app and tests

I would love to test the STOMP Android Demo App. Can you point to the exact URL, please?

zhxnlai commented 5 years ago

@alfredorueda Sorry, we only have integration tests for STOMP. We don't have a demo for STOMP because we couldn't find a public STOMP server to connect to. You could checkout other demos and here for examples to use Scarlet to establish a STOMP connection

spipau commented 5 years ago

I tried and failed to implement a STOMP connection because of a lack of documentation. Please add a working example and not just the tests, even if you don't connect to a real server. I will now shift to another solution/library.

forresthopkinsa commented 5 years ago

@zhxnlai I work(ed) on possibly the most popular Android ws/STOMP library, and I've completely ceased supporting it, telling consumers to instead use Scarlet for their websocket needs. Tinder should be far better equipped to support the huge number of people needing to use WS in their apps.

Please document your library so that those people don't try to use your carefully architected code and end up hitting a dead end.

morozione commented 4 years ago

Can you please provide an example of how to use the Scarlet as a stomp client? I've been looking for it for a couple of months but didn't get anything useful. Now I'm using another library in the prod for this but it works not well(