Change in toolchain definition is not detected?

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building

Other

397 stars 59 forks source link

Change in toolchain definition is not detected? #101

Open weedless opened 2 years ago

weedless commented 2 years ago

Hi!

I am working with a C++ project and wanted to apply bazel-diff there. When I do changes in a toolchain definition (e.g. in a typical cc_toolchain_config.bzl file) it seems not to be detected.

Bazel handles toolchain resolution implicit to the target definitions. Could it be that bazel-diff misses those dependencies when it runs a normal query? In our project we add toolchains using the command line parameter --extra_toolchains which is not supported when running a bazel query.

tinder-maxwellelliott commented 1 year ago

I think this capability could fix this? https://github.com/Tinder/bazel-diff/commit/3098e2798eb8f35ded18d5b32751fc84f0c762b6