search

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building
Other
397 stars 59 forks source link

Revert "fix: pass on target depends itself (#138)" #150

Closed tinder-maxwellelliott closed 2 years ago

tinder-maxwellelliott commented 2 years ago

This reverts commit 68e99f10cefa1a0c5b0f355f1e60e1bf3ccc682a.

Fixes #147

arie-stripe commented 2 years ago

Thanks for addressing this so quickly! 🙂

tinder-maxwellelliott commented 2 years ago

Thanks for addressing this so quickly! 🙂

This worked for you with local testing?

arie-stripe commented 2 years ago

@tinder-maxwellelliott yup!

No warning message, but I'm fine with that. Just thought I'd point it out in case that's what you wanted.

❱❱❱ git clone https://github.com/Tinder/bazel-diff.git
Cloning into 'bazel-diff'...
remote: Enumerating objects: 1517, done.
remote: Counting objects: 100% (540/540), done.
remote: Compressing objects: 100% (222/222), done.
remote: Total 1517 (delta 297), reused 416 (delta 248), pack-reused 977
Receiving objects: 100% (1517/1517), 571.23 KiB | 2.30 MiB/s, done.
Resolving deltas: 100% (568/568), done.
❱❱❱ cd bazel-diff
❱❱❱ git checkout maxwelle/revert_cyclic_fix
branch 'maxwelle/revert_cyclic_fix' set up to track 'origin/maxwelle/revert_cyclic_fix'.
Switched to a new branch 'maxwelle/revert_cyclic_fix'
❱❱❱ bazel build //cli:bazel-diff_deploy.jar
Starting local Bazel server and connecting to it...
INFO: Analyzed target //cli:bazel-diff_deploy.jar (41 packages loaded, 990 targets configured).
INFO: Found 1 target...
INFO: From KotlinCompile //cli:cli-lib { kt: 31, java: 0, srcjars: 0 } for darwin:
warning: '-Xuse-experimental' is deprecated and will be removed in a future releaseTarget //cli:bazel-diff_deploy.jar up-to-date:
  bazel-bin/cli/bazel-diff_deploy.jar
INFO: Elapsed time: 66.040s, Critical Path: 40.35s
INFO: 49 processes: 12 internal, 31 darwin-sandbox, 6 worker.
INFO: Build completed successfully, 49 total actions
❱❱❱ cd ../huge-monorepo
❱❱❱ java -jar ../bazel-diff/bazel-bin/cli/bazel-diff_deploy.jar generate-hashes -b $(which bazel) -w $PWD hashes.json
Loading: 0 packages loaded
Loading: 0 packages loaded

Loading: 0 packages loaded
Loading: 0 packages loaded
Loading: 0 packages loaded

Loading: 0 packages loaded
❱❱❱ echo $?
0
❱❱❱ wc -l hashes.json
<huge_number> hashes.json
arie-stripe commented 2 years ago

@tinder-maxwellelliott sorry if I'm being a bother, but do you know when this might get merged/released? I can always fork but I'd prefer not to if you plan to cut a release soon 🙂

Thanks again!