search

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building
Other
397 stars 59 forks source link

generate-hashes outputs hashes for invalid targets #152

Closed AndrewGuenther closed 2 years ago

AndrewGuenther commented 2 years ago

When I run generate-hashes I can see that hashes are output for every target and target output, but also for every source file. This means that when I then call get-impacted-targets I get a lot of output that's....not targets. I can filter that output list to only include targets I suppose, but that's definitely not the behavior I was expecting...

A bit more background: We use file globbing in targets fairly extensively. We don't have one target per file like many other Bazel users do. I suspect this has something to do with it?

AndrewGuenther commented 2 years ago

Of course the moment I post an issue I have my "aha" moment. Closing