Closed bz-canva closed 1 year ago
Thanks!
Thanks @tinder-maxwellelliott ! Do you mind releasing a new version so that we can use it directly from this repo?
Thanks @tinder-maxwellelliott ! Do you mind releasing a new version so that we can use it directly from this repo?
Done
Thank you sooooo much!
I'm aware that it's recommended to consume the generated impacted target list with
bazel query
, as suggested in https://github.com/Tinder/bazel-diff/issues/173 and https://github.com/Tinder/bazel-diff/issues/151. However, our use case is that we do want to avoid the extra 30-60s spent onbazel query
(we have a huge workspace).This PR adds a
--includeTargetType
option togenerate-hashes
command, which will add "target type" to the generated JSON like this:Later, an extra
--targetType=Rule
can be used inget-impacted-targets
command to filter out the targets with specific type.This may be not what you like, but it does help us a lot so I'm contributing this from our fork.
The tests are updated accordingly.