search

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building
Other
405 stars 60 forks source link

fix: Handle canonical repo name for cquery #224

Closed honnix closed 2 months ago

honnix commented 2 months ago

Not directly address #196 but this fix is required to work with bzlmod where canonical repo name is used.

This doc talks about canonical name: https://docs.google.com/document/d/1N81qfCa8oskCk5LqTW-LNthy6EBrDot7bdUsjz6JFC4/edit#heading=h.5mcn15i0e1ch

CLAassistant commented 2 months ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

honnix commented 2 months ago

@tinder-maxwellelliott Could you please take a look and see whether this makes sense? Thank you. I will look into how to get CLA signed.

honnix commented 2 months ago

I'm not exactly sure how long it would take me to get CLA signed, so please feel free to take this change (if it makes sense of course) to another PR and close this one. Thank you.

honnix commented 2 months ago

@tinder-maxwellelliott Thank you for approving this. As I said please feel free to take this change in a new PR and close this one. It would be great if you could drop a new release. Thank you.