search

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building
Other
397 stars 59 forks source link

Implement target distance metrics #230

Closed alex-torok closed 1 week ago

alex-torok commented 4 weeks ago

Add target distance metrics to measure how far away an impacted target is from a directly impacted target. I tried to keep the commits relatively concise, so reviewing them one-by-one from the beginning may be easier than looking at all of the changes at once.

Fixes #223

CLAassistant commented 4 weeks ago

CLA assistant check
All committers have signed the CLA.

alex-torok commented 3 weeks ago

@tinder-maxwellelliott - I added a new E2E test that better showcases target / package distances with a new test workspace.

I don't think there is anything else I need to do here.

tinder-maxwellelliott commented 3 weeks ago

@alex-torok There have been some changes in main for BCR support, once those are resolved I can merge this

alex-torok commented 2 weeks ago

@tinder-maxwellelliott Let me know if there is anything else I can do to help land this.

tinder-maxwellelliott commented 1 week ago

@tinder-maxwellelliott Let me know if there is anything else I can do to help land this.

Looks like there are some test failures

alex-torok commented 1 week ago

I think I fixed it, but won't be able to run it locally and see until later today.

alex-torok commented 1 week ago

@tinder-maxwellelliott - should be passing now (at least it is on my machine)

erikkerber commented 1 week ago

I don't know if it was an intentional side-effect, but the format changes mean hashes generated pre-8.0.1 will fail parsing on 8.0.1+. We noticed since we store digests per commit on CI to speed everything up.

It's pretty transient on our part because we fall back to no work avoidance when bazel-diff fails, but others might be a little surprised.

honnix commented 3 days ago

I don't know if it was an intentional side-effect, but the format changes mean hashes generated pre-8.0.1 will fail parsing on 8.0.1+. We noticed since we store digests per commit on CI to speed everything up.

It's pretty transient on our part because we fall back to no work avoidance when bazel-diff fails, but others might be a little surprised.

We are having the same problem. This change is indeed surprising. I'm wondering what could be a migration path.