Closed alex-torok closed 1 week ago
@tinder-maxwellelliott - I added a new E2E test that better showcases target / package distances with a new test workspace.
I don't think there is anything else I need to do here.
@alex-torok There have been some changes in main for BCR support, once those are resolved I can merge this
@tinder-maxwellelliott Let me know if there is anything else I can do to help land this.
@tinder-maxwellelliott Let me know if there is anything else I can do to help land this.
Looks like there are some test failures
I think I fixed it, but won't be able to run it locally and see until later today.
@tinder-maxwellelliott - should be passing now (at least it is on my machine)
I don't know if it was an intentional side-effect, but the format changes mean hashes generated pre-8.0.1 will fail parsing on 8.0.1+. We noticed since we store digests per commit on CI to speed everything up.
It's pretty transient on our part because we fall back to no work avoidance when bazel-diff fails, but others might be a little surprised.
I don't know if it was an intentional side-effect, but the format changes mean hashes generated pre-8.0.1 will fail parsing on 8.0.1+. We noticed since we store digests per commit on CI to speed everything up.
It's pretty transient on our part because we fall back to no work avoidance when bazel-diff fails, but others might be a little surprised.
We are having the same problem. This change is indeed surprising. I'm wondering what could be a migration path.
Add target distance metrics to measure how far away an impacted target is from a directly impacted target. I tried to keep the commits relatively concise, so reviewing them one-by-one from the beginning may be easier than looking at all of the changes at once.
Fixes #223