bazel-diff breaks with --noenable_workspace

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building

Other

397 stars 59 forks source link

bazel-diff breaks with --noenable_workspace #236

Closed fweikert closed 6 days ago

fweikert commented 3 weeks ago

The external package no longer exists when --noenable_workspace is specified, thus breaking bazel-diff:

https://buildkite.com/bazel/bazel-bazel-github-presubmit/builds/23693#annotation-'diff_failed'

I expect many more users to run into this problem in the near future since --noenable_workspace will be the default in Bazel 8 (ETA EOY 2024), and with Bazel 9 any WORKSPACE functionality will cease to exist.

meteorcloudy commented 3 weeks ago

/cc @maxwellE

maxwellE commented 3 weeks ago

I can look into this next after I get the tool on the BCR

honnix commented 6 days ago

I think this shouldn't be hard to fix. It is a matter of optionally adding https://github.com/Tinder/bazel-diff/blob/32c728850200bbb3fbf0664d675ae9c05a69e800/cli/src/main/kotlin/com/bazel_diff/bazel/BazelClient.kt#L16, if I understood correctly.

meteorcloudy commented 6 days ago

Yes, //external no longer exists after disabling WORKSPACE.