search

Tinder / bazel-diff

Performs Bazel Target Diffing between two revisions in Git, allowing for Test Target Selection and Selective Building
Other
406 stars 60 forks source link

fix: Use consistent labels for cquery #244

Closed honnix closed 1 month ago

honnix commented 1 month ago

Closes #238

Use --consistent_labels when cquery is used to make sure the outputs of starlark format aligns with proto format.

We could chose to always use --consistent_labels but it will be a breaking change for users who use query, bzlmod, and set --fineGrainedHashExternalRepos.

Strictly speaking, this is also a breaking change for users who use cquery, bzlmod, and set --fineGrainedHashExternalRepos, but since bazel_diff doesn't really work for this combination (see #238), I think it is acceptable.

I modified those two zip files adding common --java_runtime_version=remotejdk_11 to .bazelrc, otherwise cquery would fail.

CLAassistant commented 1 month ago

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

honnix commented 1 month ago

I'm not entirely sure this change is reasonable, so please let me know if something doesn't make sense. Thanks.