search

TinkerBell14 / Todos-App

This is a demo app for Todo list
0 stars 0 forks source link

[Android Bootcamp] - ToDo app - Ready for Review #1

Open TinkerBell14 opened 9 years ago

TinkerBell14 commented 9 years ago

My App is complete, please review. /cc @codepathreview @codepath

nesquena commented 9 years ago

Anuradha,

Sorry for the delay here, we don't typically start reviewing applications until the end of the previous cohort. Apologies for any confusion as a result.

Looks good, this exercise is intended in part to give you an introduction to the general rhythm of this course. The course is entirely project based with an app being assigned each week and then due the following week. Each project builds on the last to help each engineer to learn all practical Android development and best practices as quickly as possible. We also do a code review for each submitted project.

The next step is to continue working on extensions to your todo app and to schedule a short 10 minute phone conversation with us. Navigate to today's date and onward from there and choose a 15-minute slot. Let us know if none of those times work.

Once you select a slot, can you make sure to include best number to reach you at to the invite? Look forward to chatting soon!

TinkerBell14 commented 8 years ago

Hi,

I have added some more features to the APP -

Added - Due date, Priority, Status and sharing feature with whats app

nesquena commented 8 years ago

Great to see you were able to augment your app with a few extension tasks now. As mentioned earlier, the extension tasks available on each project are often the most valuable learnings since they dive deeper into common real-world Android use cases.

Next, after review, I noticed your source code is not adhering to certain key naming conventions. In addition, the java files could greatly benefit from being organized into subpackages. Can you take a look at this guide on code best practices to cleanup the source code?

Ping me back here when ready for a followup,

nesquena commented 8 years ago

Wanted to check in here to make sure you received my message. Let me know if you have any questions related to applying the feedback to cleanup your code.