search

TinkerSoc / TinkerWeb

Hugo based TinkerSoc website port
http://tinkersoc.org
0 stars 5 forks source link

Pulling in recent changes to live #36

Closed egelmex closed 7 years ago

willfurnell commented 7 years ago

I think the below the fold button needs to be sorted (or removed) before this is merged.

egelmex commented 7 years ago

Worth reverting that change? So we can get the other fixes live?

On Mon, 28 Aug 2017 at 11:45 Will Furnell notifications@github.com wrote:

I think the below the fold button needs to be sorted (or removed) before this is merged.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TinkerSoc/TinkerWeb/pull/36#issuecomment-325321367, or mute the thread https://github.com/notifications/unsubscribe-auth/AAc7niREPEmBGa9JRJoVxaTHELwtAVVyks5scpo1gaJpZM4PEO5l .

graymalkin commented 7 years ago

Yeah it's a bit whack on mobile for now. I might have a play over the next day or two

On 28 Aug 2017, at 11:45, Will Furnell notifications@github.com<mailto:notifications@github.com> wrote:

I think the below the fold button needs to be sorted (or removed) before this is merged.

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/TinkerSoc/TinkerWeb/pull/36#issuecomment-325321367, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADd8RqTiI1p2MK2dgu_1lLlWnW8fV08nks5scpo1gaJpZM4PEO5l.

-- Kentforlife.net - the email service for alumni of the University of Kent

willfurnell commented 7 years ago

Oh whoops I hadn't checked it on mobile. Yeah it looks awful there, and isn't needed on that either actually, will display: none;.

egelmex commented 7 years ago

Are we good to pull this now?

graymalkin commented 7 years ago

Looks okay to me. If Will also approves I'll press the button and send it live

On 28 Aug 2017, at 18:43, Martin Ellis notifications@github.com<mailto:notifications@github.com> wrote:

Are we good to pull this now?

— You are receiving this because your review was requested. Reply to this email directly, view it on GitHubhttps://github.com/TinkerSoc/TinkerWeb/pull/36#issuecomment-325423797, or mute the threadhttps://github.com/notifications/unsubscribe-auth/ADd8RqrtJ-MQccWLArFcaYBAtswxRajrks5scvwlgaJpZM4PEO5l.

-- Kentforlife.net - the email service for alumni of the University of Kent