Closed misterbrandonwalker closed 1 year ago
Hi Brandon, Do you have an example molecule with this situation? If you really mean sp2 oxygen, then it must be a positively charged oxygen? I can make this change, but I'd like to see and example and think about whether your change is "general". Thanks, Jay
Oh my so sorry that was a typo I meant SP3 oxygen! I will add an image of situation though.
Atom number 5 is the oxygen I was referring to, and atom 19 the neighboring SP3 carbon and 25 is the neighboring SP2 carbon. What will happen is the oxygen will wind up in its own polarization group, so I added a case to combine 19 and 25.
But that's just an ether.. We have "always" made the oxygen atom a separate group in ethers. We've typically only included the attached sp3 carbon in the group with the oxygen when the other attachment on the oxygen is a hydrogen, as in alcohols. Same when the heteroatom is a nitrogen instead of an oxygen... You might ask Pengyu to see what he thinks about this. I know alkyl ethers work just fine with the oxygen in its own group.
This molecule we are dealing with has issues when O is a group by itself. One side of the O is an aromatic benzyl ring which has very strong polarization. It may be ok for sp3 C on both sides. Also there is aCa2+ polarizing the Os.
If you try to minimize the molecule below using tinker.key.org (O 5 &6 are single groups), there is convergence issue. Once we put O in a group with Csp3 (aromatic C should be fine too), minimization has no issues. https://biomol.bme.utexas.edu/~pren/down/cryptand/
From: Jay Ponder @.> Sent: Monday, October 3, 2022 11:34 AM To: TinkerTools/tinker @.> Cc: Subscribed @.***> Subject: Re: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
But that's just an ether.. We have "always" made the oxygen atom a separate group in ethers. We've typically only included the attached sp3 carbon the group with the oxygen when the other attachment is a hydrogen, as in alcohols. Same when the heteroatom is a nitrogen instead of an oxygen... You might ask Pengyu to see what he thinks about this. I know alkyl ethers work just fine with the oxygen in its own group.
- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTinkerTools%2Ftinker%2Fpull%2F121%23issuecomment-1265725466&data=05%7C01%7C%7C9e6f978c3dca4916bcec08daa55d1266%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004116417191237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m%2FuYu3SBMiqN2mpvir7k7AFzhjkdMAfsn3tB%2Fjd8bMQ%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNC6XSJJ42ZBP6KVYWYMG3WBMDHHANCNFSM6AAAAAAQ3XXFQM&data=05%7C01%7C%7C9e6f978c3dca4916bcec08daa55d1266%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004116417191237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NhHP2SuPIWCMlfh2RIP7n3pKsLZT7SQPHy0oLVtbZY8%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>
Actually, I think it is better to include O with the aromatic C or sp2 C, instead of sp3 C, as they are strongly coupled. It is more appropriate to think they belong to one group.
Anyway please test the molecule below.
From: Pengyu Ren @.> Sent: Monday, October 3, 2022 11:54 AM To: TinkerTools/tinker @.> Cc: Ren, Pengyu @.>; Your activity @.> Subject: Re: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
This molecule we are dealing with has issues when O is a group by itself. One side of the O is an aromatic benzyl ring which has very strong polarization. It may be ok for sp3 C on both sides. Also there is aCa2+ polarizing the Os.
If you try to minimize the molecule below using tinker.key.org (O 5 &6 are single groups), there is convergence issue. Once we put O in a group with Csp3 (aromatic C should be fine too), minimization has no issues. https://biomol.bme.utexas.edu/~pren/down/cryptand/
From: Jay Ponder @.<mailto:@.>> Sent: Monday, October 3, 2022 11:34 AM To: TinkerTools/tinker @.<mailto:@.>> Cc: Subscribed @.<mailto:@.>> Subject: Re: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
But that's just an ether.. We have "always" made the oxygen atom a separate group in ethers. We've typically only included the attached sp3 carbon the group with the oxygen when the other attachment is a hydrogen, as in alcohols. Same when the heteroatom is a nitrogen instead of an oxygen... You might ask Pengyu to see what he thinks about this. I know alkyl ethers work just fine with the oxygen in its own group.
- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTinkerTools%2Ftinker%2Fpull%2F121%23issuecomment-1265725466&data=05%7C01%7C%7C9e6f978c3dca4916bcec08daa55d1266%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004116417191237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=m%2FuYu3SBMiqN2mpvir7k7AFzhjkdMAfsn3tB%2Fjd8bMQ%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNC6XSJJ42ZBP6KVYWYMG3WBMDHHANCNFSM6AAAAAAQ3XXFQM&data=05%7C01%7C%7C9e6f978c3dca4916bcec08daa55d1266%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004116417191237%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=NhHP2SuPIWCMlfh2RIP7n3pKsLZT7SQPHy0oLVtbZY8%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.mailto:***@***.******@***.***>>
- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTinkerTools%2Ftinker%2Fpull%2F121%23issuecomment-1265747923&data=05%7C01%7C%7Cdb543d597d2a435da9a008daa55fdc33%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004128382160657%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=gd%2Fdxs9%2BDQGcVEFrF%2Bpe5Cavx1sPXqPwfFx4UAHSRW4%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNC6XQDYJAVYK7L6EM2G2LWBMFRDANCNFSM6AAAAAAQ3XXFQM&data=05%7C01%7C%7Cdb543d597d2a435da9a008daa55fdc33%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004128382316895%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=lcPvRPitniAoB0j00j1M4Tcx49GRsjNdrBsGIqylkL8%3D&reserved=0. You are receiving this because you are subscribed to this thread.Message ID: @.**@.>>
Yes, what Pengyu suggests is better. It makes more sense to put the oxygen in the same group as the phenyl/aromatic carbon it is attached to (and therefore in the same group with the whole aromatic ring). For example, that is what we do for tyrosine, even though it is an "alcohol"/phenol and not an ether. Then the group should break between the oxygen and the sp3 carbon on the other side. That is more consistent with what we have done in the past. I'll make that change when I get a chance- probably later today. Best, Jay
Thank you!
Jay, The benzene seems not in one group either, which it should.
Thanks Pengyu
From: Jay Ponder @.> Sent: Monday, October 3, 2022 12:27 PM To: TinkerTools/tinker @.> Cc: Ren, Pengyu @.>; Comment @.> Subject: Re: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
Yes, what Pengyu suggests is better. It makes more sense to put the oxygen in the same group as the phenyl/aromatic carbon it is attached to (and therefore in the same group with the whole aromatic ring). For example, that is what we do for tyrosine, even though it is an "alcohol"/phenol and not an ether. Then the group should break between the oxygen and the sp3 carbon on the other side. That is more consistent with what we have done in the past. I'll make that change when I get a chance- probably later today. Best, Jay
- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTinkerTools%2Ftinker%2Fpull%2F121%23issuecomment-1265791605&data=05%7C01%7C%7Cc3cf25144a234e2b68db08daa56475d8%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004148135654172%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AydwqFWtTWfNuXMdZnwYW4oq5uD0dzcSFdolMiwU2Hc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNC6XXSVRDOKX2FUMACUF3WBMJNTANCNFSM6AAAAAAQ3XXFQM&data=05%7C01%7C%7Cc3cf25144a234e2b68db08daa56475d8%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004148135654172%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RowyqOjItp81fHCsVYBexgoI4YftLwKoywgWkUG7094%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>
Probably false alarm about benzene ring as one group. Will check myself.
From: Ren, Pengyu Sent: Monday, October 3, 2022 12:32 PM To: TinkerTools/tinker @.>; TinkerTools/tinker @.> Cc: Comment @.***> Subject: RE: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
Jay, The benzene seems not in one group either, which it should.
Thanks Pengyu
From: Jay Ponder @.**@.>> Sent: Monday, October 3, 2022 12:27 PM To: TinkerTools/tinker @.**@.>> Cc: Ren, Pengyu @.**@.>>; Comment @.**@.>> Subject: Re: [TinkerTools/tinker] Poledit polarization group assignment, add special case (PR #121)
Yes, what Pengyu suggests is better. It makes more sense to put the oxygen in the same group as the phenyl/aromatic carbon it is attached to (and therefore in the same group with the whole aromatic ring). For example, that is what we do for tyrosine, even though it is an "alcohol"/phenol and not an ether. Then the group should break between the oxygen and the sp3 carbon on the other side. That is more consistent with what we have done in the past. I'll make that change when I get a chance- probably later today. Best, Jay
- Reply to this email directly, view it on GitHubhttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2FTinkerTools%2Ftinker%2Fpull%2F121%23issuecomment-1265791605&data=05%7C01%7C%7Cc3cf25144a234e2b68db08daa56475d8%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004148135654172%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=AydwqFWtTWfNuXMdZnwYW4oq5uD0dzcSFdolMiwU2Hc%3D&reserved=0, or unsubscribehttps://nam12.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FABNC6XXSVRDOKX2FUMACUF3WBMJNTANCNFSM6AAAAAAQ3XXFQM&data=05%7C01%7C%7Cc3cf25144a234e2b68db08daa56475d8%7C31d7e2a5bdd8414e9e97bea998ebdfe1%7C0%7C0%7C638004148135654172%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000%7C%7C%7C&sdata=RowyqOjItp81fHCsVYBexgoI4YftLwKoywgWkUG7094%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>
The benzene group is a single group, I was interpreting the key wrong...
Please send me by email the XYZ, DMA and/or key file for the molecule, and I will take a look. Obviously the whole phenyl ring should be in the same group.
22benzocryptand-peditin.txt 22benzocryptand.gdmaout.txt 22benzocryptand.key.txt 22benzocryptand.xyz.txt
Hi Jay,
Here are the files (have to add .txt extension since github is picky). The xyz/key generated will have the oxygen included in the group with the change I made, before that the oxygen is in its own group.
Hi Brandon, I've made this change to the main Tinker repo on GitHub (separate from this pull request..). Sorry for the delay. Jay
.
No worries, thanks!
Need to add special case for poledit polarization groups, with current code SP2 oxygen will be in group by itself if between an SP3 carbon and an SP2 carbon, this allows oxygen and SP3 carbon to be in same group.