search

TinkerTools / tinker

Tinker: Software Tools for Molecular Design
https://dasher.wustl.edu/tinker/
Other
130 stars 61 forks source link

buildmake.py usage is incorrect #57

Closed mquevill closed 4 years ago

mquevill commented 4 years ago

In make/0README, the instructions say to run ./buildmake.py ../source, but when you attempt to call this, it throws an IsADirectoryError. The full error message is listed below:

Traceback (most recent call last):
  File "./buildmake.py", line 364, in <module>
    categorize_fortran_files(sys.argv[1:])
  File "./buildmake.py", line 271, in categorize_fortran_files
    stem, filetype, use_list = determine_module_subroutine_program(filename)
  File "./buildmake.py", line 227, in determine_module_subroutine_program
    content = [line.rstrip().lower() for line in open(fortran_filename)]
IsADirectoryError: [Errno 21] Is a directory: '../source'

If I am understanding this script properly, it should be run with

./buildmake.py ../source/*.f > Makefile
zhi-wang commented 4 years ago

@mquevill You are absolutely correct. The README file should have been updated.

@jayponder

jayponder commented 4 years ago

This is now fixed. Thanks!