TinkerTools / tinker

Tinker: Software Tools for Molecular Design
https://dasher.wustl.edu/tinker/
Other
130 stars 61 forks source link

Poledit frame assignment z-then-bisector on hydrogen on aromatic ring. #90

Closed misterbrandonwalker closed 3 years ago

misterbrandonwalker commented 3 years ago

Hello,

Noticed small issue special case with this molecule, basically benzene but replace one of C with N.

The frame on the hydrogen attached to N gives z and the x in the same direction and causes MD to crash.

C5H5NH+.gdmaout.txt C5H5NH+.key.txt C5H5NH+-peditin.txt

jayponder commented 3 years ago

Hi Brandon,

Thanks for sending this. It was indeed a small bug that would only happen for this type of pyridinium hydrogen and perhaps some other very similar things. It is now fixed in the Tinker release/master branch on Github in a general way, and should not happen again.

Best, Jay

misterbrandonwalker commented 3 years ago

Thanks!

On Wed, Jun 30, 2021 at 2:16 PM Jay Ponder @.***> wrote:

Closed #90 https://github.com/TinkerTools/tinker/issues/90.

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TinkerTools/tinker/issues/90#event-4961649452, or unsubscribe https://github.com/notifications/unsubscribe-auth/AKNB26MHTGNG2CW3DHTZEGLTVNUQRANCNFSM47RBDXKQ .

pren commented 3 years ago

For H(N) in aniline, the best choice is to use the bisector frame between the two C next to N.

From: Jay Ponder @.> Sent: Wednesday, June 30, 2021 2:16 PM To: TinkerTools/tinker @.> Cc: Subscribed @.***> Subject: Re: [TinkerTools/tinker] Poledit frame assignment z-then-bisector on hydrogen on aromatic ring. (#90)

Hi Brandon,

Thanks for sending this. It was indeed a small bug that would only happen for this type of pyridinium hydrogen and perhaps some other very similar things. It is now fixed in for the Tinker release/master branch on Github in a general way, and should not happen again.

Best, Jay

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHubhttps://github.com/TinkerTools/tinker/issues/90#issuecomment-871662498, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ABNC6XWDWTWSZUGA3E7ZPXDTVNUQRANCNFSM47RBDXKQ.

jayponder commented 3 years ago

Hi Pengyu,

The case Brandon had was a pyridinum hydrogen. This is an aromatic system that is completely flat. The hydrogen on nitrogen cannot have a Z-Bisector local frame, but that's what POLEDIT gave. POLEDIT is/was aware of this situation, and the improper behavior was a bug in the planarity check for this specific situation of a monovalent atom attached to a trivalent nitrogen. It is now fixed.

As we know, trivalent nitrogens are a huge pain in AMOEBA- in my opinion they are the very worst situation for our local frame mechanisms. As we have discussed many times before, if the trivalent nitrogen can pass through planar during a calculation, then none of the local frames on either the nitrogen or the attached atoms can be Z-Bisector or Trisector.

For the H(N) in pyridinium (you say aniline above, but I think you mean pyridinium), the corrected POLEDIT will choose a Z-then-X frame to the nitrogen as the "Z" and then pick one of the two carbons as the "X". The Tinker code does not support the kind of frame you suggest, using a Bisector frame involving two atoms (carbons) that are neither one bonded to the atom being defined (hydrogen). Adding that option would be kind of a mess, and I'd rather not go there. Various things depend on the local frame using a directly attached atom when one is present (the nitrogen, in the pyridinium case). Yes, if the molecule is simple symmetric pyridinium, then the current POLEDIT breaks symmetry. But it's a relatively rigid aromatic ring and the symmetry break will be tiny. The very same argument could be made for just a benzene hydrogen. You could suggest that we skip the attached carbon and use a Bisector frame to the two adjacent carbons. We've never used that kind of "Bisector" local frame.