-loadfile parameter is now read in correctly

TinkerWorX / SharpCraft-retired-

SharpCraft is a library that helps modding Warcraft III: The Frozen Throne.

GNU General Public License v2.0

40 stars 10 forks source link

-loadfile parameter is now read in correctly #29

Closed ChiefOfGxBxL closed 8 years ago

ChiefOfGxBxL commented 8 years ago

The issue was that the quotes were being stripped when the argument was passed in to Launcher.exe, so since there may be spaces in the path, the argument was being split up into multiple "arguments". The quotes need to be re-established when a path to a .w3x file is present so the path remains intact.

Closes #28.

TinkerWorX commented 8 years ago

I forgot to add. Please make PRs to the dev branch. This way I can make sure they're working before moving them into master.

ChiefOfGxBxL commented 8 years ago

@TinkerWorX Thanks for the code review, good suggestions. I left some comments above to follow-up on yours.

Re-based the PR to merge into dev as requested.

TinkerWorX commented 8 years ago

Looks like everything is in order. I appreciate the help!