search

Tinkerforge / esp32-firmware

Firmwares for ESP32 Brick and ESP32 Ethernet Brick (including firmwares for WARP/WARP2 Charger, WARP Energy Manager)
https://www.tinkerforge.com/en/doc/Hardware/Bricks/ESP32_Ethernet_Brick.html
26 stars 20 forks source link

wrong localized number in chrome #236

Closed breitsi closed 1 year ago

breitsi commented 1 year ago

My up to date chrome userAgent give me this string: navigator.userAgent =>"Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/112.0.0.0 Safari/537.36"

in your statement, chrome use the "false" case 

return navigator.userAgent.indexOf("Gecko/") >= 0
                ? util.toLocaleFixed(x, digits)
                : (x).toFixed(digits);

the result isn't a localized number

https://github.com/Tinkerforge/esp32-firmware/blob/3933d22a1c335f29b6e8a2d932778d70beaba8ce/software/web/src/ts/components/output_float.tsx#L39

rtrbt commented 1 year ago

Fixed with 2c8c2e4. Thank you!