search

Tinkoff / Horarium

Horarium is the .Net library to manage background jobs
Apache License 2.0
56 stars 12 forks source link

#16: introduced IJobExecutionContext and IJobExecutionContextFactory #19

Closed wite27 closed 5 years ago

wite27 commented 5 years ago

See #16 @Bobreshovr take a look on my proposal of fix #16, please. If it's ok i'll fix up tests :)

Bobreshovr commented 5 years ago

Will this realization work for other DI? Example SimpleInjector

Bobreshovr commented 5 years ago

Could you please add documentation about this factory? With example SimpleInjector. It would be nice.

wite27 commented 5 years ago

Will this realization work for other DI? Example SimpleInjector

I suppose, yes, but I'll take a look anyway.

Could you please add documentation about this factory? With example SimpleInjector. It would be nice.

Of cource. Any plans to add new assembly Horarium.SimpleInjector?

Bobreshovr commented 5 years ago

Of cource. Any plans to add new assembly Horarium.SimpleInjector?

Not now, but if someone wants to add SimpleInjector. It should be easy.

codecov-io commented 5 years ago

Codecov Report

Merging #19 into master will decrease coverage by 0.5%. The diff coverage is 41.93%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   58.43%   57.93%   -0.51%     
==========================================
  Files          28       29       +1     
  Lines         806      813       +7     
==========================================
  Hits          471      471              
- Misses        335      342       +7
Impacted Files Coverage Δ
src/Horarium/DefaultJobFactory.cs 0% <0%> (ø) :arrow_up:
src/Horarium/HorariumServer.cs 30.43% <0%> (ø) :arrow_up:
src/Horarium.AspNetCore/JobScope.cs 0% <0%> (ø)
src/Horarium/Handlers/ExecutorJob.cs 100% <100%> (ø) :arrow_up:
src/Horarium/HorariumSettings.cs 100% <100%> (ø) :arrow_up:
...rarium.AspNetCore/RegistrationHorariumExtension.cs 76.19% <100%> (ø) :arrow_up:
src/Horarium.AspNetCore/JobScopeFactory.cs 57.14% <57.14%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 26cb0c1...2a9a13b. Read the comment docs.