search

Tinkoff / Nginx-builder

A tool to build deb or rpm package of required Nginx version from the source code, with the ability to connect third-party modules. Nginx parameters are set in the yaml configuration file.
Apache License 2.0
154 stars 28 forks source link

не добавляется --with для embedded для модуля, у которого есть флаг git_url #17

Closed patsevanton closed 5 years ago

patsevanton commented 5 years ago

config.yaml

nginx_version: 1.14.0
output_package: rpm
modules:
  - module:
      name: http_dav_module
      git_url: https://github.com/arut/nginx-dav-ext-module.git
      git_tag: v3.0.0
      type: embedded
      dependencies:
        - libxml2-devel
        - libxslt-devel

Log

builder - INFO - Downloading 3d-party modules...
builder - INFO - Module http_dav_module will download by tag
builder - INFO - -- Done: http_dav_module

++ echo -O2 ... --with-cc-opt= --with-ld-opt= --add-module=/root/rpmbuild/SOURCES/modules/http_dav_module ...
patsevanton commented 5 years ago

Fixed in https://github.com/TinkoffCreditSystems/Nginx-builder/pull/18

Frodox commented 5 years ago

Верно. а зачем?

Frodox commented 5 years ago

--with-http_dav_module скомпилирует встроенный (из исходников Nginx) модуль. если хочется собрать не встроенный, а внешний модуль, то и опция цшер не нужна

therb1 commented 5 years ago

Проблема решена в PR #19 и PR #18