feat(eslint-config): set import/no-cycle to error - Githubissues

Tinkoff / linters

Tinkoff ESlint, Stylelint and Prettier linter configurations

Apache License 2.0

125 stars 24 forks source link

feat(eslint-config): set import/no-cycle to error #206

Closed ddubrava closed 1 year ago

ddubrava commented 1 year ago

PR Checklist

Please check if your PR fulfills the following requirements:

[x] The commit message follows Conventional Commits
[ ] Tests for the changes have been added (for bug fixes / features)
[ ] Docs have been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Refactoring
[ ] Code style update
[ ] Build or CI related changes
[ ] Documentation content changes

What is the current behavior?

import/no-cycle is disabled

What is the new behavior?

import/no-cycle is enabled

Does this PR introduce a breaking change?

[x] Yes
[ ] No

ddubrava commented 1 year ago

Hey! I added some settings to use import/export without a typescript parser

parserOptions: {
  sourceType: "module",
},
env: {
  es6: true,
},

ddubrava commented 1 year ago

@splincode could you help with the failing test? I don’t get why it’s not passed