Tinkoff / micro-sentry

Tiny Sentry client with idiomatic wrapper for Angular
Apache License 2.0
118 stars 8 forks source link

[BUG] "@micro-sentry/core" peer dependency in "@micro-sentry/angular" package #1

Closed hakimio closed 3 years ago

hakimio commented 3 years ago

🐞 Bug report

Description

Since @micro-sentry/core is peer dependency instead of "hard" dependency, user has to install it explicitly. Either installation instructions should be updated or @micro-sentry/core should be upgraded to "hard" dependency.

sentry core

MarsiBarsi commented 3 years ago

Hey Tomas 👋 Thank you very much for your issue! Interesting...

So, the angular package has a "hard" dependency to @micro-sentry/browser that uses @micro-sentry/core inside. But it does not use @micro-sentry/core directly at all and it is not in its peer deps. @IKatsuba take a look, please, it seems that something (nx? builders?) adds extra peer dependency while building

hakimio commented 3 years ago

@MarsiBarsi @micro-sentry/browser hard dependency in your @micro-sentry/angular library doesn't make any sense as well. The latest @micro-sentry/browser version is 2.0.0 while your @micro-sentry/angular depends on v0.xx:

  "dependencies": {
    "tslib": "^2.1.0",
    "@micro-sentry/browser": "^0.0.1"
  }
MarsiBarsi commented 3 years ago

We have a custom semrel angular builder here that should solve this case automatically but something went wrong :( Igor will check the builder and one of us will check the problem about added peer soon

github-actions[bot] commented 3 years ago

:tada: This issue is included in version core@2.0.1 :tada:

The release is available on GitHub release

github-actions[bot] commented 3 years ago

:tada: This issue is included in version browser@2.0.1 :tada:

The release is available on GitHub release

github-actions[bot] commented 3 years ago

:tada: This issue is included in version angular@2.0.1 :tada:

The release is available on GitHub release