search

TinoGuo / pin_input_text_field

A textField widget to help display different style pin
Apache License 2.0
374 stars 81 forks source link

FormField's value not updated when TextEditingController not supplied #18

Closed alyyasser closed 4 years ago

alyyasser commented 4 years ago

there's strange issue when creating PinInputTextFormField without supplying TextEditingController in constructor parameter. when using TextEditingController from inside _PinInputTextFormFieldState, it'll not update the value, that value will be used in validator, onSave, and other callback in PinInputTextFormField.

after investigating the logic i implemented before, it turns out i did it wrong (sorry). will land the PR to fix it soon. i've done the fix in my local repo.

TinoGuo commented 4 years ago

Thanks for your contribution. Don't feel guilty, you're pretty good.