search

TinoGuo / pin_input_text_field

A textField widget to help display different style pin
Apache License 2.0
368 stars 81 forks source link

Added StrokeCap to underline decoration #66

Closed anisalibegic closed 3 years ago

TinoGuo commented 3 years ago

Hi, thanks PR. need to check 2 things

  1. is it eligible for all decoration? if so, we need to apply all decorations
  2. pls update the test to pass the check
anisalibegic commented 3 years ago
  1. It only works with UnderlineDecoration since it's the only decoration that's not closed curve. Box and circle decoration have no hard edges to round.
  2. Yes, I probably could do that.
anisalibegic commented 3 years ago

@TinoGuo I belive this can be merged now since all checks have passed.