Degrade gracefully for unsupported browsers

TinyCircuits / TinyCircuits-Thumby-Code-Editor

https://code.thumby.us/

GNU General Public License v3.0

30 stars 20 forks source link

Degrade gracefully for unsupported browsers #8

Open ace-dent opened 3 years ago

ace-dent commented 3 years ago

The readme makes it clear that only specific browsers are supported (due to current adoption of WebSerial). However, many casual users will just try to use the Web IDE in their default (unsupported) browser- which just makes things appear... broken...

Please degrade gracefully. After doing a browser check, warn the user about compatibility issue. Consider allowing certain functions to still be useable- such as the bitmap editor.

ghost commented 3 years ago

This does happen to some level now. This is what happens if you try to use it in Firefox: Although we do not go through and try to ensure everything works on the unsupported browsers.

ace-dent commented 3 years ago

Doesn't work for me with macOS Safari... no warning box is shown.... :-(

ghost commented 3 years ago

OK, I'll try to implement a check for the Safari browser in the next version of the IDE.

ghost commented 1 year ago

Is this still an issue today? Detecting which browser on which OS is a whole can of worms. It's weird that WebSerial is detected in Safari.

The detection happens here: https://github.com/TinyCircuits/TinyCircuits-Thumby-Code-Editor/blob/430a4b2b5b5e03d68fe832d050ff902bcad05482/js/repl.js#L55-L60