TinyCircuits / TinyCircuits-Thumby-Code-Editor

https://code.thumby.us/
GNU General Public License v3.0
28 stars 19 forks source link

Update `Thumgeon` button code to use API #99

Closed ace-dent closed 1 year ago

ace-dent commented 1 year ago

As a 'core' game, Thumgeon should use the Thumby API where possible; in part for best practice/ education. The custom button handling code should be replaced with API equivalents. This also avoids the extra import of Pin from machine.

ace-dent commented 1 year ago

Corresponding issue for Arcade Repo is here.

ghost commented 1 year ago

I removed the base games from this repository in https://github.com/TinyCircuits/TinyCircuits-Thumby-Code-Editor/commit/38fc1b83b39f81db1592b33763955318bb97d106, now they're just on the Arcade https://github.com/TinyCircuits/TinyCircuits-Thumby-Games.

This and https://github.com/TinyCircuits/TinyCircuits-Thumby-Code-Editor/pull/97 shouldn't be needed here anymore.

ace-dent commented 1 year ago

Thanks @jmtinycircuits . Appreciate this! Issue is now just with the Arcade version. Closing duplicate.