TinyModularThings / IC2Classic

IC2Classic Bugtracker
141 stars 39 forks source link

Visual error: Pipes still render while foamed, and have incorrect lighting. #1139

Open AstoriaFloyd opened 2 months ago

AstoriaFloyd commented 2 months ago

Partial duplicate of #1138, with more detail.

I had incorrectly stated that foamed blocks did not render properly due to still being transparent. I have since discovered this is not the case. Rather, after being foamed, wires and pipes cease to render their original forms and become identical to construction foam blocks. Tubes do NOT do this, which I believe is unintentional. Tubes continue to render their original model underneath the construction foam, which would explain the incorrect lighting. It could also help performance if items inside tubes did not render when they are foamed. Here is the setup I used to test this 2024-04-05_16 48 51 2024-04-05_16 48 53

2024-04-05_16 49 27 2024-04-05_16 49 33 2024-04-05_16 49 42 2024-04-05_16 49 56 2024-04-05_16 53 39 2024-04-05_16 53 49

Speiger commented 2 months ago

@AstoriaFloyd yeah there is a slight difference in code defining which rendertype it is in, the models on the other hand are equal, quite literally.

I will have to look into it deeper and see if that breaks functionality or not or if it solves the problem or not.

About tubes not rendering their stuff when foamed. The tube itself won't hurt performance since its just another block worth of quads inside of the simple chunk renderer. Which is the most efficient renderer inside mc itself. And items only cause render lag if they are inside, and that can be turned of with the tube tool.

But I am at the moment at a coding break due to IRL reasons that are more important then modding. So don't expect this being addressed anytime soon.