search

TinyModularThings / UniqueEnchantments

Have some Unique Enchantments for yourself
https://www.curseforge.com/minecraft/mc-mods/unique-enchantments
Other
18 stars 16 forks source link

Super log spam #34

Closed someaddons closed 3 years ago

someaddons commented 3 years ago

Even more log spam

https://github.com/TinyModularThings/UniqueEnchantments/blame/1.16.5/src/main/java/uniquee/utils/IdStat.java#L100

Remove the darn system out please, next time at least use a logger

Speiger commented 3 years ago

Oops. This was a debug test that was missing. Also System.out is still a logger xD even if it is the most direct way

Speiger commented 3 years ago

Fixed and patch was submitted to curseforge

someaddons commented 3 years ago

xD ye the issue is that finding the cause of the system out is harder since it doesnt log which mod it does

Speiger commented 3 years ago

Yeah, but for a temp logger that has no use outside of a indev test thing I won't create one. If i have like logging everywhere if i have beta tests running then i would do it. But a single: Am i working testdebug. I rather use easiest accessible logger. In 1.7.10 it was FMLLog.getLog().info("TestMyThing"); now its System.out.println("TestMyThing");