TinyModularThings / UniqueEnchantments

Have some Unique Enchantments for yourself
https://www.curseforge.com/minecraft/mc-mods/unique-enchantments
Other
18 stars 16 forks source link

Unique enchantments causes game crashes and erases 'library' when used with Enchantment Machine #60

Closed AuroraHydroid closed 2 years ago

AuroraHydroid commented 2 years ago

For 1.16.5, when Unique Enchantments is used with Enchantment Machine (url: https://www.curseforge.com/minecraft/mc-mods/enchantment-machine), the game crashes if the enchanter is used (for instance enchanting a book). Additionally, any books that were put into the enchanting 'library' are erased.

UE was found to be the culprit by a process of elimnation. The crash log lies.

crash-2022-06-09_21.42.04-fml.txt .

Xaikii commented 2 years ago

are you sure that's the right file? that tells me you don't have crafttweaker installed also pls use pastebin or similar for logs

AuroraHydroid commented 2 years ago

Here's the correct crashlog: https://pastebin.com/PXSnVfz8

Speiger commented 2 years ago

@AuroraHydroid UE isn't even mentioned in the log and anything we change would trigger UE to be in the logs.

AuroraHydroid commented 2 years ago

I'm not sure why it isn't showing in the logs, and that's why this is a frustrating issue. Here is a crash log with only UE and EM enabled. UE is the only thing that is causing it to crash. If it's not possible to find it on this end, I'll see if EM can find anything.

https://pastebin.com/sq3sNRrr

Speiger commented 2 years ago

Yeah found the bug. It is within enchantment machine. https://github.com/Cheaterpaul/EnchantmentMachine/blob/1.18/src/main/java/de/cheaterpaul/enchantmentmachine/client/gui/screens/inventory/EnchanterScreen.java#L140

Basically what the bug is. Enchantment machine expects the "Color" of the Name to be not null. UE adds icons which are not colored (null) which enchantment machine doesn't account for and crashes.

Yes this is a UE caused, but the bug is not within UE because minecraft clearly defines that "Colors" can be null and the dev didn't account for that.

Speiger commented 2 years ago

Opened issue with Enchanting machine since its their bug.

AuroraHydroid commented 2 years ago

Thank you very much for your time! I appreciate the expertise.

Speiger commented 2 years ago

@AuroraHydroid fix should be out from his side.