TinyModularThings / UniqueEnchantments

Have some Unique Enchantments for yourself
https://www.curseforge.com/minecraft/mc-mods/unique-enchantments
Other
18 stars 16 forks source link

[UniqueBase, 1.16.5] Key bind hash map can get negative array bounds crash if world is loaded whilst window not in focus #64

Closed Kaleidio closed 1 year ago

Kaleidio commented 2 years ago

Only crashes whilst initializing a world in singleplayer, if the window was not in focus whilst it was opening. Seemingly random and uncommon crash but has happened multiple times now to me.

https://pastebin.com/KM19gk6i

simple protection against negative bounds may or may not work. it is possible this method needs to tick at a different time as well. tracelog contains no mention of any other mods nor their mixins so I cannot suspect a conflict. It might be some awfully nested forge bug with where postClientTick gets fired at a time uniquebase does not expect.

Speiger commented 2 years ago

Ok, yeah this is a edge case that might have been slipped. I look at it the moment i am not rewriting 6 mods at the same time.

Speiger commented 2 years ago

Ok should be fixed now