search

TinyTapeout / xschem-viewer

Online viewer of Xschem schematic files
https://xschem-viewer.com/
Apache License 2.0
20 stars 1 forks source link

xschem-viewer vscode version #7

Closed barakhoffer closed 4 months ago

barakhoffer commented 4 months ago

I think it would be cool to do a vscode extension xschem-viewer version, where you can use vscode preview to quickly move and browse schematics. I can also take part in the development.

urish commented 4 months ago

Indeed! Would love if you took part in the development

barakhoffer commented 4 months ago

I created a very simple POC for this, see here: vscode-xschem-viewer

urish commented 4 months ago

Cool!

Do you plan to publish it to the VS Code marketplace?

barakhoffer commented 4 months ago

Yes I will publish it 😄 Do you have any rejections/comments? Thanks

urish commented 4 months ago

Thanks!

Overall it looks good. A few things I noticed:

  1. When opening a file, the initial zoom level is off. Not sure if it's due to the extension or xschem-viewer itself:

image

  1. Would be nice to also open .sym files (right now, it only deals with .sch files)

  2. Marketplace listing:

image

Icon is missing, and Tiny Tapeout should be written this way. We'd appreciate a shout out to Tiny Tapeout in the README, something along the lines of:

Tiny Tapeout is an educational project that aims to make it easier and cheaper than ever to get your digital and analog designs manufactured on a real chip.

To learn more and get started, visit https://tinytapeout.com/.

Not mandatory, but will definitely make us happy to see it.

barakhoffer commented 3 months ago

Thanks for the comments! The zoom level seems to be xschem-viewer itself, do you have a zoom-to-fit function or something like that? Also, can I use the Tiny Tapeout icon for the vscode marketplace?

urish commented 3 months ago

The zoom level seems to be xschem-viewer itself, do you have a zoom-to-fit function or something like that?

Yes, not sure why it's not working correctly though:

https://github.com/TinyTapeout/xschem-viewer/blob/86601ea4227ce95b1f6a8fbece50cd230349d60e/src/components/SchematicView.tsx#L62

Also, can I use the Tiny Tapeout icon for the vscode marketplace?

You mean here?

image

Or somewhere else?

barakhoffer commented 3 months ago

yes, the icon as you marked

urish commented 3 months ago

In that case, IMHO it makes sense to use Xschem icon - @stefanSchippers are you good with it?

StefanSchippers commented 3 months ago

@urish no problem. Use the icon / image / logo you like more and think it's best for the purpose.

barakhoffer commented 3 months ago

done :) vscode-xschem-viewer

urish commented 3 months ago

Great, TYSM!

One more suggestion: include a screen shot in the README

curtisma commented 3 months ago

Awesome, exactly what I need! 💯 Thanks for the great work @barakhoffer, @urish, and @StefanSchippers!

I've been thinking about the need for this over the last month or two. I even presented the idea at a conference panel last month and all the panelists agree that a vscode xschem schematic editor would be awesome. It was the "Will open source design be the future direction?" panel at the IEEE CICC conference in Denver on April 24th.