search

TinyWATCH-S3 / Official-firmware

Official firmware for Unexpected Maker's TinyWATCH S3
GNU General Public License v3.0
16 stars 7 forks source link

imu: Check for imu_ready in all cases #24

Closed disq closed 8 months ago

disq commented 8 months ago

These were missing

UnexpectedMaker commented 8 months ago

Oh, cool, thanks!

UnexpectedMaker commented 8 months ago

Yeah, as I said in discord, please install clang-format and enable it on save so this doesn't happen in the future :)

UnexpectedMaker commented 8 months ago

you commited your display.cpp changes. please remove those.

This is why code must be tested on the watch before raising a PR ;)

UnexpectedMaker commented 8 months ago

weird, the comment didn't appear until just now. maybe put them in separate PRs in the future as the PR is about the IMU I thought you accidentally committed something you weren't supposed to.

UnexpectedMaker commented 8 months ago

Thanks for the PR