search

TinyWATCH-S3 / Official-firmware

Official firmware for Unexpected Maker's TinyWATCH S3
GNU General Public License v3.0
16 stars 7 forks source link

fix: Try saving steps manually before and after hibernation #5

Closed disq closed 8 months ago

disq commented 8 months ago

Untested, ~uncompiled,~ an fix attempt for #4

IMU::set_hibernate is never called with true so went with a separate method.

~also is it tabs, is it spaces, went with spaces for now, will change depending on feedback.~

UnexpectedMaker commented 8 months ago

Sorry, but won't merge untested code. See docs on formatting. Strictly TABS.

disq commented 8 months ago

Intended for feedback only. You don't need to merge anything, just wanted feedback before proceeding further. ie. maybe saving it everytime isn't a good idea, and so on.

UnexpectedMaker commented 8 months ago

I don't even follow what your code is doing, sorry. I don't see how any of what you have written solves the "how to capture steps when the S3 is asleep" issue. There is no need to capture the steps before and "persist" them, as they are already saved as they happen.

Not sure a PR is the right way to be discussing this tbh.

disq commented 8 months ago

Will reopen later and cleaner