search

Tiph-Studios / DysonSphereProject

A mod for Minecraft
Apache License 2.0
0 stars 0 forks source link

getShape is depreciated #40

Closed zhouzhouthezhou closed 10 months ago

zhouzhouthezhou commented 11 months ago

According to SonarLint getShape is depreciated and should not be overridden. We should figure out the up to date way to create a slab-ish block

    @Override
    public VoxelShape getShape(
            BlockState p_60555_, BlockGetter p_60556_, BlockPos p_60557_, CollisionContext p_60558_) {
        return SHAPE;
    }
zhouzhouthezhou commented 11 months ago

maybe this is ok idk image

zhouzhouthezhou commented 10 months ago

I guess action item here is to see how other neoforged mods do it. I've been using https://vscode.dev/github/JDDev0/EnergizedPower/ as a reference point

PJWahlgren commented 10 months ago

Every other mod uses it. Begone!