search

Tiph-Studios / DysonSphereProject

A mod for Minecraft
Apache License 2.0
0 stars 0 forks source link

runData error #51

Open zhouzhouthezhou opened 9 months ago

zhouzhouthezhou commented 9 months ago

Caused by: com.google.gson.stream.MalformedJsonException: Use JsonReader.setLenient(true) to accept malformed JSON at line 6 column 20 path $.pack.pack_format

when trying to execute runData

zhouzhouthezhou commented 9 months ago

happens on 79ada193efddb30b0505b8e98bff782fe68e73d2 as well

zhouzhouthezhou commented 9 months ago

[main/ERROR] [minecraft/AbstractPackResources]: Couldn't load filter metadata

zhouzhouthezhou commented 9 months ago

from @XFactHD

That's caused by the resources being passed to the game slightly differently between a normal run and a datagen run. In a normal run, the resources come from /build/resources and have been handled by Gradle such that things like the processResources task touched them. In a datagen run, the resources come directly from src/main/resources to prevent the datagen system from seeing generated resources. While this shouldn't cause any actual issues, you can fix it by either hard-coding the pack format value in the pack.mcmeta or generating the pack.mcmeta with datagen as well: https://github.com/XFactHD/FramedBlocks/blob/1.20.3/src/main/java/xfacthd/framedblocks/common/datagen/GeneratorHandler.java#L49-L63. Do note though that the datagen code will break in the very near future as we are planning to remove the packtype-specific format versions in favor of vanilla's pack compatibility system

zhouzhouthezhou commented 9 months ago

from @XFactHD

The PR for it is open and needs reviewing: https://github.com/neoforged/NeoForge/pull/365. There is no definite timeline I can give you though