Tiqa / redux-polyglot

Polyglot.js bindings for Redux
MIT License
58 stars 13 forks source link

getLocale()/getPhrases() can return a falsy value. #17

Open guillaumearm opened 7 years ago

guillaumearm commented 7 years ago

for v1.0

need #16

this will stop the progression :

about this behavior :

JalilArfaoui commented 7 years ago

I think it should return next(action), not return action

guillaumearm commented 7 years ago

yes, you're right. i don't remember why I thought to do that when I wrote this issue :)

guillaumearm commented 7 years ago

I remember ! (for return action)

it's about SET_LANGUAGE action. we shouldn't propagate this action ( and only this action ) when return a falsy value.

but that's no longer news since #38. so don't worry about this ;-)