getP() and translate() : add optional scope parameter

Tiqa / redux-polyglot

Polyglot.js bindings for Redux

MIT License

58 stars 13 forks source link

getP() and translate() : add optional scope parameter #29

Closed guillaumearm closed 7 years ago

guillaumearm commented 7 years ago

from #28 add polyglotScope notion.

guillaumearm commented 7 years ago

waiting for the new implementation ( the curried way ). see issue #28.

JalilArfaoui commented 7 years ago

@guillaumearm I don't really like the way getP can take the scope directly as a string ... I think it should receive a 'propsy' object as we discussed. Only the translate enhancer should take either a string or an object IHMO. This PR is already merged, so I will think about it and PR if I can propose a better implementation.